PWGHF: update of DDbar correlation code (remove obsolete tasks + add process switch) by fcolamar · Pull Request #314 · AliceO2Group/O2Physics

fcolamar · 2021-11-22T10:37:34Z

No description provided.

…process switch)

fcolamar · 2021-11-26T11:21:08Z

Thanks Vit, I implemented your comments in the code

fcolamar · 2022-01-10T09:12:35Z

Hello @vkucera and @ginnocen, I think that with my last commit all the comments raised were addresses, could you confirm that this is ok so this PR can be merged? Thanks!

vkucera · 2022-01-26T12:54:59Z

Hello @vkucera and @ginnocen, I think that with my last commit all the comments raised were addresses, could you confirm that this is ok so this PR can be merged? Thanks!

Hi @fcolamar , sorry for taking long to come back to this PR. Thanks for the fixes. I just have one small naming suggestion.

fcolamar · 2022-01-27T15:11:53Z

Hi @vkucera, thanks, just fixed with the new commit, ciao!

vkucera · 2022-02-01T08:25:03Z

Hi @fcolamar , can you please resolve the conflicts?

fcolamar · 2022-02-03T08:27:26Z

Hi @vkucera, should be ok now: the conflicts were due to the McParticles_000 updates done on the previous version of the code (while the new was in the open PR). Now everything should be ok unless further modifications are made meanwhile

alibuild · 2022-02-04T15:24:06Z

Error while checking build/O2Physics/o2 for bfe863f at 2022-02-04 16:23:

No log files found

Full log here.

vkucera · 2022-02-05T13:47:52Z

Thanks @fcolamar for the fix.
I see that you use the following binnings at many places:

{100, -5., 5.}
{32, 0., 2. * o2::constants::math::PI}
{120, 1.5848, 2.1848}

I would suggest to define them once as variables and then use only the variables in the histogram declarations instead. It will save you a lot of changes if you decide to change the binning.

* Extend PID utils * - Throw fatal if requested value is not available

* add V0Link table to finder * Rename HF tables, adjust index to V0

…liceO2Group#503)

jgrosseo · 2022-02-08T12:57:52Z

Please rebase properly and then reopen

* PWGLF / h-Str correlations: allow for subwagons for systematics * Please consider the following formatting changes (#314) * PWGLF: Changes to allow for systematics via subwagons * Fix types * Please consider the following formatting changes (#315) * Fix typo * Megalinter fix --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>

…eO2Group#7155) * PWGLF / h-Str correlations: allow for subwagons for systematics * Please consider the following formatting changes (AliceO2Group#314) * PWGLF: Changes to allow for systematics via subwagons * Fix types * Please consider the following formatting changes (AliceO2Group#315) * Fix typo * Megalinter fix --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>

PWGHF: update of DDbar correlation code (remove obsolete tasks + add …

ca2d0bd

…process switch)

fcolamar requested review from alibuild, ginnocen and vkucera as code owners November 22, 2021 10:37

vkucera marked this pull request as draft November 23, 2021 13:32